git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: hooks not fired by a merge's auto-commit

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 29, 2010, 16:50 UTC
Message-ID
<7vzkxatepy.fsf@alter.siamese.dyndns.org>
In-Reply-To
<AANLkTindr-y0uAu46FVEqtB5BLw9ZjB0y0ETwmW+8+PV@mail.gmail.com>
Richard Bronosky <Richard@Bronosky.com> writes:
Show 5 quoted lines
> Using git 1.7.1 it seems that a merge (more specifically the
> auto-commit) does not fire any of the following hooks:
> pre-commit  prepare-commit-msg commit-msg
>
> Is that by design?

I would probably call it an unintended design that now has long been established that changing it may break people's existing setups rather badly.

Especially pre-commit hooks that look for and prevent common mistakes from happening for individual developers may not want to run, when you are pulling in other people's work that already has the mess they created. Such problems are often either too late to fix or you are in no position to reject their pull requests. So you would break _my_ workflow (and others who play similar roles as me, making changes themselves and merging others work) if you did such a change.

You _could_ add pre-merge to introduce it as a new feature. For people who want to apply the same check for merges and individual commits (e.g. those who never merge other's work), pre-merge can just invoke pre-commit.

Previous: Richard BronoskyNext: Jay Soffian
Message 2 of 3 in “hooks not fired by a merge's auto-commit”
  1. Richard BronoskyJul 29, 2010
  2. Junio C HamanoJul 29, 2010
  3. Jay SoffianAug 1, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.