Re: 'Unable to find remote helper'

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 8, 2010, 18:54 UTC
Message-ID: <7vzktjprwt.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101104224010.GA18693@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 5 quoted lines

> The "gmake clean" undoes the effect of "./configure".
>
> Hope that helps.
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>

You diagnosed the problem correctly, but I do not think the patch is correct. Why should the generated file *.autogen be kept around across "clean"?

I do understand why we keep "configure" around (it is common for everybody once it is generated), though.

Show 23 quoted lines

> ---
> diff --git a/Makefile b/Makefile
> index d3dcfb1..c693652 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2229,7 +2229,7 @@ dist-doc:
>  ### Cleaning rules
>  
>  distclean: clean
> -	$(RM) configure
> +	$(RM) configure config.mak.autogen
>  
>  clean:
>  	$(RM) *.o block-sha1/*.o ppc/*.o compat/*.o compat/*/*.o xdiff/*.o vcs-svn/*.o \
> @@ -2240,7 +2240,7 @@ clean:
>  	$(RM) -r $(dep_dirs)
>  	$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
>  	$(RM) -r autom4te.cache
> -	$(RM) config.log config.mak.autogen config.mak.append config.status config.cache
> +	$(RM) config.log config.mak.append config.status config.cache
>  	$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
>  	$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
>  	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz