git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 2/3] diffstat: Use new diff.stat config values

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 29, 2010, 20:24 UTC
Message-ID
<7vzksr280s.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4CF2EB05.5090300@case.edu>
Matthew Ruffalo <mmr15@case.edu> writes:
> From f3ca8d4222776fb38a2def4fb9c4691c09c1e0fd Mon Sep 17 00:00:00 2001
> From: Matthew Ruffalo <matthew.ruffalo@case.edu>
> Date: Sun, 28 Nov 2010 14:44:00 -0500
> Subject: [PATCH 2/3] diffstat: Use new diff.stat config values
Please drop these lines --- I can see them in the header of your e-mail.
> Previously, the diffstat width could only be specified with the
> command-line options '--width' and '--name-width'. This patch adds
> support for config file options 'diff.stat.width' and
> 'diff.stat.namewidth'.

In general, the second level in a three-level configuration variable name is to choose which one of unbound set of things to set the value for, and the last level of a configuration variable name is to name the specific property to affect (e.g. "difftool.<tool>.path" "remote.<name>.url").

So this sounds more like "diffstat.width" and "diffstat.namewidth". There is no set of "<something>" that share "namewidth" property to warrant the name "diff.<something>.namewidth".

The idea of the patch is good. But the message is heavily whitespace damaged and cannot be applied. Please check the settings of your MUA.

Thanks.
Previous: Matthew RuffaloNext: mmr15@case.edu
Message 2 of 6 in “diffstat: Use new diff.stat config values”
  1. 2/3 diffstat: Use new diff.stat config valuesMatthew Ruffalo, Nov 28, 2010
  2. Junio C HamanoNov 29, 2010
  3. 1/3 diffstat width: #define defaults in diff.hmmr15@case.edu, Dec 8, 2010
  4. 2/3 diffstat: Use new diffstat config valuesmmr15@case.edu, Dec 8, 2010
  5. Junio C HamanoDec 9, 2010
  6. 3/3 Add documentation for new diffstat config optionsmmr15@case.edu, Dec 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.