Re: [PATCH] t/README: unify documentation of test function args
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 25, 2011, 19:31 UTC
- Message-ID
- <7vzknei0vn.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4DB5BDBE.308@debugon.org>
Mathias Lafeldt <misfire@debugon.org> writes:
> Ah, okay. Is this true for test_expect_code too? It also has a git command > in the example, but it says <command>, not <git-command>: > > - test_expect_code <exit-code> <command>
I think that one is Ok as there is no git specific hacks in the semantics. It is a straight "Run this command, and make sure you get this exit code".
The "must-fail" is really a special case in that we just do not expect any failure, but expect a controlled failure. Currently we only catch segv, but we should anticipate that we will reject other types of uncontrolled failures in the future, and keeping the function "git-only" makes it easier to manage.