git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-completion: fix zsh support

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 27, 2011, 16:56 UTC
Message-ID
<7vzknb8wgd.fsf@alter.siamese.dyndns.org>
In-Reply-To
<BANLkTinep961dg9v3TD8hZZAvTYL3_H+xg@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 10 quoted lines
> On Wed, Apr 27, 2011 at 7:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
> ...
>> I'd love to share the enthusiasm, but find that "as we can see" needs a
>> much more clarification.
>
> Jonathan already described it:
> http://article.gmane.org/gmane.comp.version-control.git/170665
>
> And this snipped demonstrates it:
> ...

When I say "needs more clarification" during a review, I am not asking the contributor to explain it in the discussion thread to _me_ who happen to be asking at that moment. I am asking the contributor to explain it to people who will read "git log" output 6 months down the road.

You have been here long enough to know that "Jonathan already described it" that is not connected in the commit that is going to be recorded is not something we appreciate, no?

In any case, the message of Jonathan's
    Subject: [RFC/PATCH] completion: avoid "words" as variable name for zsh portability
    Date: Wed, 27 Apr 2011 01:40:34 -0500
    Message-ID: <20110427064033.GB4226@elie>

seems to explain it better. The naming of variables and other details might need to be settled, but other than that is it correct to understand that we will see a final version along the line of that patch?

Thanks.
Previous: Felipe ContrerasNext: Felipe Contreras
Message 26 of 28 in “git-completion: fix zsh support”
  1. git-completion: fix zsh supportFelipe Contreras, Apr 27, 2011
  2. Jonathan NiederApr 27, 2011
  3. Felipe ContrerasApr 27, 2011
  4. Junio C HamanoApr 27, 2011
  5. completion: avoid "words" as variable name for zsh portabilityJonathan Nieder, Apr 27, 2011
  6. Felipe ContrerasApr 27, 2011
  7. Jonathan NiederApr 27, 2011
  8. Felipe ContrerasApr 27, 2011
  9. John SzakmeisterApr 27, 2011
  10. Felipe ContrerasApr 27, 2011
  11. completion: move private shopt shim for zsh to __git_ namespaceJonathan Nieder, Apr 27, 2011
  12. Felipe ContrerasApr 27, 2011
  13. Jonathan NiederApr 27, 2011
  14. Jonathan NiederMay 6, 2011
  15. Felipe ContrerasMay 6, 2011
  16. SZEDER GáborMay 8, 2011
  17. SZEDER GáborApr 28, 2011
  18. 1/3 bash: don't modify the $cur variable in completion functionsSZEDER Gábor, Apr 28, 2011
  19. 2/3 bash: remove unnecessary _get_comp_words_by_ref() invocationsSZEDER Gábor, Apr 28, 2011
  20. 3/3 bash: don't declare 'local words' to make zsh happySZEDER Gábor, Apr 28, 2011
  21. Felipe ContrerasMay 3, 2011
  22. Felipe ContrerasApr 28, 2011
  23. Junio C HamanoApr 28, 2011
  24. Felipe ContrerasApr 28, 2011
  25. Felipe ContrerasApr 27, 2011
  26. Junio C HamanoApr 27, 2011
  27. Felipe ContrerasApr 27, 2011
  28. Jonathan NiederApr 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.