Re: [PATCH v4 1/4] t5541-http-push: add test for chunked
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 4, 2011, 18:23 UTC
- Message-ID
- <7vzkn2e34y.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <m3wri6vg5h.fsf@localhost.localdomain>
Jakub Narebski <jnareb@gmail.com> writes:
Show 5 quoted lines
> It is a very minor issue, a nitpick really; but wouldn't it be better > to use > > + git config http.postbuffer 4 && > + test_when_finished "git config --unset http.postbuffer" &&
Not a minor issue it is. It needs to be fixed before queued. Thanks for pointing it out.
It is a different matter if it needs to be rerolled. Something trivial like this I could remember to amend/tweak before queuing.
Thanks.