Re: [PATCH] Fix test t3701-add-interactive.sh

From: Junio C Hamano <gitster@pobox.com>
Date: May 5, 2011, 18:27 UTC
Message-ID: <7vzkn16m0q.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110505165029.GD31229@camk.edu.pl>

Kacper Kornet <draenog@pld-linux.org> writes:

Show 22 quoted lines

> One of the tests used to fail due to EOF not in the first column and not
> continued &&.
>
> Signed-off-by: Kacper Kornet <draenog@pld-linux.org>
> ---
>  t/t3701-add-interactive.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
> index d6327e7..018f5d9 100755
> --- a/t/t3701-add-interactive.sh
> +++ b/t/t3701-add-interactive.sh
> @@ -83,9 +83,9 @@ EOF
>  
>  test_expect_success PERL 'setup fake editor' '
>  	cat >fake_editor.sh <<EOF
> -	EOF
> +EOF
>  	chmod a+x fake_editor.sh &&
> -	test_set_editor "$(pwd)/fake_editor.sh" &&
> +	test_set_editor "$(pwd)/fake_editor.sh"
>  '

Very curious. I never saw the breakage.  We are getting:

./test-lib.sh: line 450: warning: here-document at line 447 delimited by end-of-file (wanted `EOF')

Well spotted.  Thanks.