git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] am: learn passing -b to mailinfo

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 12, 2012, 01:35 UTC
Message-ID
<7vzkdt4s9l.fsf@alter.siamese.dyndns.org>
In-Reply-To
<19539098c07a207f3bd24f5a145ba3b6c5e46766.1326312730.git.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
Show 10 quoted lines
> @@ -571,8 +574,8 @@ then
>  else
>  	utf8=-n
>  fi
> -if test "$(cat "$dotest/keep")" = t
> -then
> +keep=$(cat "$dotest/keep")
> +if test "$keep" = t
>  	keep=-k
>  fi
Curious.
Who writes 't' to $dotest/keep after this patch is applied?

I also do not want to worry about "echo" portability issues that may come from an existing

	echo "$keep" >"$dotest/keep"
that this patch does not touch.

I suspect that this patch was not tested in a way to exercise this codepath; shell would have barfed when seeing the lack of "then" here, no?

Previous: Thomas RastNext: Thomas Rast
Message 3 of 9 in “mailinfo documentation: accurately describe non -k case”
  1. 1/3 mailinfo documentation: accurately describe non -k caseThomas Rast, Jan 11, 2012
  2. 2/3 am: learn passing -b to mailinfoThomas Rast, Jan 11, 2012
  3. Junio C HamanoJan 12, 2012
  4. Thomas RastJan 12, 2012
  5. 1/2 am: learn passing -b to mailinfoThomas Rast, Jan 16, 2012
  6. 2/2 mailinfo: with -b, keep space after [foo]Thomas Rast, Jan 16, 2012
  7. Junio C HamanoJan 19, 2012
  8. Thomas RastJan 20, 2012
  9. 3/3 mailinfo: with -b, keep space after [foo]Thomas Rast, Jan 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.