Re: [PATCH] contrib: added git-diffall

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2012, 21:06 UTC
Message-ID: <7vzkca8to9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAFouetgyYRKT7h1h4hv40Kxp=ibq1Hw-1mzFe6DsyAUknXKyYQ@mail.gmail.com>

Tim Henigan <tim.henigan@gmail.com> writes:

Show 5 quoted lines

> I have not heard back from the user, but I tested on Ubuntu earlier
> today.  I found that when using an older version of the script
> (fbedb7a in the GitHub repo), I could repeat the error.  It is the
> 'git-diffall' script that fails silently, I believe due to a bash-ism
> that was fixed in a subsequent commit.

Thanks.

That would explain it, especially given that you've been doing:

> For what it is worth, since that bug was originally reported, I have
> been running "checkbashisms" [1] on the git-diffall script.  That
> utility reports that the script is clean.

The checkbashisms scritp is interesting ;-)

I do not get much of the comment removal and string munging that happen before it really start to check the contents for bash-isms, but most of the check logic contained within the %foo_bashisms seem to be looking for the right kind of mistakes people who are too used to bash make very often.