Re: [PATCH 3/6] Teach clone to set remote.default.

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 5, 2012, 22:52 UTC
Message-ID: <7vzk7dq0qk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1341526277-17055-4-git-send-email-marcnarc@xiplink.com>

marcnarc@xiplink.com writes:

Show 19 quoted lines

> From: Marc Branchaud <marcnarc@xiplink.com>
>
> Signed-off-by: Marc Branchaud <marcnarc@xiplink.com>
> ---
>  builtin/clone.c          |  2 ++
>  t/t5601-clone.sh         | 10 ++++++++++
>  t/t5702-clone-options.sh |  7 +++++--
>  3 files changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/clone.c b/builtin/clone.c
> index a4d8d25..b198456 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -770,6 +770,8 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>  	git_config_set(key.buf, repo);
>  	strbuf_reset(&key);
>  
> +	git_config_set("remote.default", option_origin);
> +

Is this something we would want to do unconditionally?  If so why?

Or is this what we want to do only when the "--origin name" option is used?