Re: [PATCH v2 2/2] Provide better guidance for submitting patches against upstream utilities

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 31, 2012, 23:39 UTC
Message-ID: <7vzk0tdc63.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1356992375-11116-3-git-send-email-jason.k.holden.swdev@gmail.com>

Jason Holden <jason.k.holden.swdev@gmail.com> writes:

Show 20 quoted lines

> git-gui, gitk, and git-po are maintained upstream of git.
> Document this, and the procedure for submitting patches to these tools
>
> Signed-off-by: Jason Holden <jason.k.holden.swdev@gmail.com>
> ---
>  Documentation/SubmittingPatches | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 75935d5..30b95a8 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -58,6 +58,17 @@ Checklist (and a short version for the impatient):
>  	  please test it first by sending email to yourself.
>  	- see below for instructions specific to your mailer
>  
> +	Improving upstream utilities (gitk, git-gui, git-po)
> +	- gitk, git-gui, and git-po are maintained upstream of Git
> +	  despite being included in Git's git repository
> +	- Patches should be made against the upstream gui repository,

GUI?

Show 5 quoted lines

> +	  and not against the version in Git's git repository
> +	- The resulting patch should still be emailed for review
> +	  to the git mailing list (git@vger.kernel.org), cc'ing the
> +	  applicable gui maintainer
> +	- Please see the MAINTAINER's file for the gui maintainer's contact

GUI?

Perhaps "parts with sub-maintainers' with their own repositories".

In any case, I think it is probably much better not to add a new file at the top of the tree only to hold twenty-or-so lines. Instead, add the contents as a footnote to this file and refer to it from here.