Re: [RFC/PATCH v2] CodingGuidelines: add Python coding guidelines

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 29, 2013, 19:34 UTC
Message-ID: <7vzjzrokag.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130129190844.GB1342@serenity.lan>

John Keeping <john@keeping.me.uk> writes:

Show 11 quoted lines

> Changes since v1:
>
> - Set 3.1 as the minimum Python 3 version
>
> - Remove the section on Unicode literals - it just adds confusion and
>   doesn't apply to the current code; we can deal with any issues if they
>   ever arise.
> ...
> + - We use the 'b' prefix for bytes literals.  Note that even though
> +   the Python documentation for version 2.6 does not mention this
> +   prefix it is supported since version 2.6.0.

Do we still need to single out the 'b' prefix? Even if it were necessary, I'd like to see it toned down a bit to make it clear that most of the time you can write strings as strings without having to worry about the "is it unicode string or a string string" mess. Like

    - When you must make distinction between Unicode literals and
      byte string literals, it is OK to use 'b' prefix.  Even though
      ...

perhaps?