git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] lookup_object: prioritize recently found objects

From
Junio C Hamano <gitster@pobox.com>
Date
May 2, 2013, 15:46 UTC
Message-ID
<7vzjwd1j27.fsf@alter.siamese.dyndns.org>
In-Reply-To
<5182101D.4050807@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
> BTW, do you notice that the function is now modifying an object (the hash
> table) even though this is rather unexpected from a "lookup" function?

At the philosophical level, "lookup" ought to be operating on a "const" table. But at the implementation level, the table does not have to be "const" in the sense the implemenation language and data structure defines.

I think this patch is a good example of that.

I am kind of surprised that Jeff's attempt to do a full LRU made things worse, though. The only additional code compared to swap is a single memmove(): are we colliding too often (having to move a lot)?

Previous: Johannes SixtNext: Jeff King
Message 6 of 12 in “lookup_object: prioritize recently found objects”
  1. lookup_object: prioritize recently found objectsJeff King, May 1, 2013
  2. Junio C HamanoMay 1, 2013
  3. Johannes SixtMay 2, 2013
  4. Jeff KingMay 2, 2013
  5. Johannes SixtMay 2, 2013
  6. Junio C HamanoMay 2, 2013
  7. Jeff KingMay 2, 2013
  8. Jeff KingMay 2, 2013
  9. Johannes SixtMay 3, 2013
  10. Jeff KingMay 3, 2013
  11. Jeff KingMay 3, 2013
  12. Junio C HamanoMay 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.