Re: clone: I'm only doing a max of 256 requests

From: Junio C Hamano <junkio@cox.net>
Date: Oct 5, 2005, 21:38 UTC
Message-ID: <7vy857iqzh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vhdbvk6ln.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 6 quoted lines

> 1. As a stop gap measure, so that your Linux kernel work can
>    continue, please bump MAX_NEEDS definition in upload-pack.c
>    from 256 to a bit higher.  That controls the number of
>    40-letter SHA1 given to underlying rev-list via execvp(), so
>    it cannot be _too_ big like 1M, lest it exceeds the exec
>    argument buffer limit.

Hmph. I was reading linux-2.6/fs/exec.c::copy_strings(), but I do not see any such size limit (other than exceeding the total machine memory size, probably reported by alloc_page() failing) imposed there. Am I looking at the wrong place?