Re: [RFC][PATCH] Allow transfer of any valid sha1
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 25, 2006, 20:53 UTC
- Message-ID
- <7vy7wpsu5c.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <m13bexetj1.fsf@ebiederm.dsl.xmission.com>
ebiederm@xmission.com (Eric W. Biederman) writes:
> So fixing fetch-pack is easy and pretty non-controversial. > The patch below handles that.
I am at work so I cannot really spend time on this right now, but I am OK with letting it send arbitrary SHA1 the caller obtained out of band. I do not know about your implementation, since I haven't really looked at it.
> (The movement of filter_refs may actually be overkill)
It may not just overkill but may actively be wrong, but again I haven't looked at it yet.
Will take a look tonight.