Re: [PATCH] Enter interactive mode if no parameters are given to git-add

From: Junio C Hamano <junkio@cox.net>
Date: Dec 19, 2006, 18:00 UTC
Message-ID: <7vy7p3pxyr.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200612191516.09606.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 5 quoted lines

> git-add with no parameters previously adds every modified file.  This
> patch instead makes git-add enter interactive mode.
> ...
> It seemed a bit nasty to add content without explicit instructions to do
> so.

Does anybody rely on the current behaviour?

It is nasty and I consider it a bug. It appears that it has been like that since the days when it was still a shell script.

While I think nobody should drive 'git add' from script, the behaviour to add everything when there is no explicit parameter (or fall back to interactive for that matter) has a problem if you say "some command | xargs git-add --" (you need "xargs -r" to fix it, which is GNU).

Let's first have a patch to exit with a warning message (but status 0) without doing anything when there is no explicit paths.

Again, does anybody rely on the current behaviour?