Re: [PATCH] The "table-of-contents" in the update hook script should match the body

From: Junio C Hamano <junkio@cox.net>
Date: Feb 14, 2007, 16:53 UTC
Message-ID: <7vy7n0r87y.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200702141120.32776.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 11 quoted lines

> 44478d99ee0 introduced a filter using "git-rev-parse --not --all" to the
> log display to prevent the display of revisions already in the
> repository.  However, the table of contents generation didn't get that
> same update.
>
> This patch fixes that.  The table of contents before the log and the log
> now both display the same list of revisions.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>
> ---
> Apologies.  I should always wait a day before posting patches.

No worries.  I will always wait a day before applying yours ;-)

Just kidding. It's not a big deal as this is purely a sample script.

Show 16 quoted lines

>  templates/hooks--update |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/templates/hooks--update b/templates/hooks--update
> index a7cf604..fd1f73d 100644
> --- a/templates/hooks--update
> +++ b/templates/hooks--update
> @@ -57,7 +57,7 @@ announcerecipients=$(git-repo-config hooks.announcelist)
>  allowunannotated=$(git-repo-config --bool hooks.allowunannotated)
>  
>  # --- Check types
> -newrev_type=$(git-cat-file -t "$newrev")
> +newrev_type=$(git-cat-file -t $newrev)
>  
>  case "$refname","$newrev_type" in
>  	refs/tags/*,commit)

I do not think this hunk is related...