Re: git-upload-pack: the timeout gets corrupted?!

From: Junio C Hamano <junkio@cox.net>
Date: Mar 11, 2007, 05:56 UTC
Message-ID: <7vy7m4wcfb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <45F35F38.1080206@zytor.com>

"H. Peter Anvin" <hpa@zytor.com> writes:

Show 7 quoted lines

> ...  Going in with gdb, it appears the "timeout"
> variable gets overwritten:
>
> (gdb) p timeout
> $1 = 608471321
>
> ... which should have been 600.

I do not see offhand what can cause this. The only new code since 1.4.4 series is "shallow clone" stuff,...

> The process spends effectively forever waiting in on the fflush() in
> show_commit() (in upload-pack.c); /proc/*/fd shows it is trying to
> write to a pipe, but I'm not sure what is at the other end of that
> same pipe.

The process forks and the one that runs show_commit() is running rev-list internally while the other end is a pack-objects that reads from it and sends its output back to the client.