Re: [RFC] format-patch stuff

From: Junio C Hamano <junkio@cox.net>
Date: May 12, 2007, 20:24 UTC
Message-ID: <7vy7jtx01y.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0705121109520.18541@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

Show 5 quoted lines

> It would be nice if git-format-patch would generate a [PATCH 0/n] message 
> at the start of the series if some option were given. This would, of 
> course, have to be editted afterwards to include actual information, but 
> it would at least be pre-generated in series and with the configured 
> headers and such.

It would be helpful for git-send-email users. I've done that by hand by copying 0001-*.txt to 0000-*.txt and editing as needed by hand.

> Shouldn't the format.headers configuration automatically apply the correct 
> line termination? Currently, you need to know to put in \r\n at the end of 
> each one, and the example isn't even right (only puts \n).

Sorry, I do not follow. Where does that "\r\n" come from? If you are talking about RFC 2822 line ending conventions, I think that is a job for MUA (including git-send-email). Remember, MUA's are not the only consumer of format-patch output.

Although "2.3. Body" says "CR and LF MUST only occur together as CRLF", the body of the text we output from format-patch is a straight text with LF termination and let the MUA handle that SMTP specific conversion. I do not think there is reason to treat the header part any differently.