Re: [PATCH] Support output ISO 8601 format dates

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 13, 2007, 22:11 UTC
Message-ID: <7vy7hklzsf.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070713202258.14107.18196.stgit@lathund.dewire.com>

Documentation/pretty-formats.txt does not talk about this addition.

Almost everything else looks fine with your patch, except that neither "git show --date=iso" nor "git log --date=iso8601" works with this change, but that is only half your fault.

When we added DATE_SHORT support we could have added the option parser to revision.c so that you could mimick it more easily. That half is my fault.

The patch, especially this hunk:

Show 12 quoted lines

> diff --git a/commit.c b/commit.c
> index 5632e32..68df3b4 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -773,6 +773,7 @@ static void fill_person(struct interp *table, const char *msg, int len)
>  	interp_set_entry(table, 2, show_date(date, tz, 0));
>  	interp_set_entry(table, 3, show_rfc2822_date(date, tz));
>  	interp_set_entry(table, 4, show_date(date, tz, 1));
> +	interp_set_entry(table, 6, show_date(date, tz, DATE_ISO8601));
>  }
>  
>  static long format_commit_message(const struct commit *commit,

makes me wonder if we would want to refactor and reimplement show_rfc2822_date() in terms of show_date(), by introducing DATE_RFC2822 in the date format enum, which will allow us to say "git show --date=rfc2822".

Hmm?