Re: [PATCH] Test case for "git diff" outside a git repo
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 24, 2007, 06:14 UTC
- Message-ID
- <7vy7h6ib0b.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20070723132248.GA24122@midwinter.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Steven Grimm <koreth@midwinter.com> writes: > >> Signed-off-by: Steven Grimm <koreth@midwinter.com> >> --- >> git-diff --quiet is pretty broken right now. If you do >> "strace git diff --quiet file1 file2" you will see that >> it never calls open() on either file! And it always >> returns a zero exit code whether or not the files are >> different. >> >> I'm trying to follow the code to figure out what's going on, >> but meanwhile, here's a test case. Perhaps someone more >> familiar with the diff code will beat me to a fix.
The code to do "untracked diff" is an ugly stepchild and not really part of git-diff proper. In fact, --quiet also is an afterthought and I would not be too surprised if the "untracked diff" code does not work with it.
Show 13 quoted lines
>> diff --git a/t/t4021-diff-norepo.sh b/t/t4021-diff-norepo.sh >> new file mode 100755 >> index 0000000..dfee3d7 >> --- /dev/null >> +++ b/t/t4021-diff-norepo.sh >> @@ -0,0 +1,26 @@ >> +#!/bin/sh >> + >> +test_description='test git diff outside a repo' >> + >> +. ./test-lib.sh >> + >> +rm -rf .git
Unless you are testing the t/ directory and git.git suite from a tarball, the only effect of this is to make t/trash controlled by its ../../.git repository (i.e. the git.git repository). You are still inside a git repository.