git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] In Examples, explain option -r and refer to git-rev-list[1]

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 27, 2007, 09:55 UTC
Message-ID
<7vy7fxjo90.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20070827084423.GA19230@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 20 quoted lines
> On Mon, Aug 27, 2007 at 01:33:49AM -0700, Junio C Hamano wrote:
>
>> --- a/builtin-log.c
>> +++ b/builtin-log.c
>> @@ -258,6 +258,7 @@ int cmd_log(int argc, const char **argv, const char *prefix)
>>  	git_config(git_log_config);
>>  	init_revisions(&rev, prefix);
>>  	rev.always_show_header = 1;
>> +	rev.diffopt.recursive = 1;
>>  	cmd_log_init(argc, argv, prefix, &rev);
>>  	return cmd_log_walk(&rev);
>>  }
>
> This should perhaps rather go in cmd_log_init (and be removed from
> cmd_show and cmd_whatchanged). I think this is semantically a little
> more clear, and the change will affect other log porcelains (right now
> just "git-reflog --name-status", but also new ones if they are added).
>
> But yes, this is post-1.5.3, so I will shut up rather than nitpicking
> your "not meant to be applied now" patches.

Thanks for your comments; rather than shutting up, could you send an improvement after 1.5.3 happens?

Previous: Jeff KingNext: Jeff King
Message 6 of 7 in “In Examples, explain option -r and refer to git-rev-list[1]”
  1. In Examples, explain option -r and refer to git-rev-list[1]Jari Aalto, Aug 26, 2007
  2. Lukas SandströmAug 27, 2007
  3. Junio C HamanoAug 27, 2007
  4. Junio C HamanoAug 27, 2007
  5. Jeff KingAug 27, 2007
  6. Junio C HamanoAug 27, 2007
  7. Jeff KingAug 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.