Re: [PATCH] In Examples, explain option -r and refer to git-rev-list[1]
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 27, 2007, 09:55 UTC
- Message-ID
- <7vy7fxjo90.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20070827084423.GA19230@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 20 quoted lines
> On Mon, Aug 27, 2007 at 01:33:49AM -0700, Junio C Hamano wrote: > >> --- a/builtin-log.c >> +++ b/builtin-log.c >> @@ -258,6 +258,7 @@ int cmd_log(int argc, const char **argv, const char *prefix) >> git_config(git_log_config); >> init_revisions(&rev, prefix); >> rev.always_show_header = 1; >> + rev.diffopt.recursive = 1; >> cmd_log_init(argc, argv, prefix, &rev); >> return cmd_log_walk(&rev); >> } > > This should perhaps rather go in cmd_log_init (and be removed from > cmd_show and cmd_whatchanged). I think this is semantically a little > more clear, and the change will affect other log porcelains (right now > just "git-reflog --name-status", but also new ones if they are added). > > But yes, this is post-1.5.3, so I will shut up rather than nitpicking > your "not meant to be applied now" patches.
Thanks for your comments; rather than shutting up, could you send an improvement after 1.5.3 happens?