Re: [PATCH] Use is_absolute_path() in diff-lib.c, lockfile.c, setup.c, trace.c

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 26, 2007, 03:54 UTC
Message-ID: <7vy7clhd9z.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <11960297431954-git-send-email-prohaska@zib.de>

Steffen Prohaska <prohaska@zib.de> writes:

> Using the helper function to test for absolute paths makes porting easier.

These probably make sense. I obviously do not see any downside from the POSIX side, and can imagine that treating "C:\" prefix as "absolute paths" at these four places will not have any ill effect on the Windows side (IOW, the codepaths that follow these four places seem to do a sensible thing even if the "absolute path" prefix is not a single '/', but would work fine as-is).

I am a bit surprised that there are only four places you needed to touch, though.

Show 6 quoted lines

> BTW, what happend to the msysgit related patches:
>
> [PATCH 1/3] sha1_file.c: Fix size_t related printf format warnings
> [PATCH 2/3] builtin-init-db: use get_git_dir() instead of getenv()
>
> I never received comments about them, nor do I find them on pu.

Lack of comments was probably due to mixture of bad timing and general lack of interests. Many people are busy working on their turkeys than hacking this time of the year ;-)

I am reluctant to queue msysgit/gitwin related patches without seeing positive comments from other people involved on the Windows side, unless they are trivial and obvious improvements.

 * [1/3] seems without harm but on the other hand does not seem so
   urgent either.

 * [2/3] may introduce chicken-and-egg problem (use of get_git_dir()
   inside git-init feels quite iffy, as it calls setup_git_env(), which
   does repository discovery), without an obvious and clear advantage.

For these reasons, both of them disqualify from being trivial and obvious improvements, so I did not pick them up unilaterally before seeing positive comments from other people.