Re: [PATCH] t4014: Replace sed's non-standard 'Q' by standard 'q'

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 23, 2008, 18:27 UTC
Message-ID: <7vy79b34w1.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <12037561161987-git-send-email-prohaska@zib.de>

Steffen Prohaska <prohaska@zib.de> writes:

Show 7 quoted lines

> This commit should be applied on top of db/cover-letter.
>
> -- >8 --
>
> This commit avoids sed's 'Q' operator.  The Open Group's sed
> man page [1] does not mention 'Q'.  sed on Mac OS X 10.4
> does not accept Q.  'q' is sufficient for our purpose.

Thanks.

Show 13 quoted lines

> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index a39e786..16aa99d 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -95,7 +95,7 @@ test_expect_success 'extra headers' '
>  	git config --add format.headers "Cc: S. E. Cipient <scipient@example.com>
>  " &&
>  	git format-patch --stdout master..side > patch2 &&
> -	sed -e "/^$/Q" patch2 > hdrs2 &&
> +	sed -e "/^$/q" patch2 > hdrs2 &&
>  	grep "^To: R. E. Cipient <rcipient@example.com>$" hdrs2 &&
>  	grep "^Cc: S. E. Cipient <scipient@example.com>$" hdrs2
>

I usually try to be pretty careful about these kind of things, but these somehow slipped in. Changing them to 'q' means the output will now have an additional blank line at the end, but that would not affect the result the later tests inspect, so it's a good change.