Re: [PATCH] "git push": tellme-more protocol extension
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 21, 2008, 04:24 UTC
- Message-ID
- <7vy78cu2kt.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080321023303.GE1613@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> 2. This can actually be _more_ network intensive than your proposal.
I do not think this matters much in practice. If you have tons of refs on _your_ side to matter, some of them would be tags that are known to both ends. The only case it really is troublesome is when the sender does not know _any_ of the refs the receiver presented to it.
In the illustration in the message you are responding to, if the commit A was tagged at the shared repository when two developers cloned, it does not matter if C is unknown to the second pusher.
So a potential improvement might be to ask for "tellme-more" only if we do not know any of the refs the receiver showed us; my patch does it if there is at least one unknown instead.