git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bash completion: Improve responsiveness of git-log completion

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 13, 2008, 21:38 UTC
Message-ID
<7vy745piqy.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080713023742.GA31760@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Junio noticed the bash completion has been taking a long time lately....
The credit actually goes to Ingo.
Show 7 quoted lines
> Petr Baudis tracked it down to 72e5e989b ("bash: Add space after
> unique command name is completed.").  Tracing the code showed
> we spent significant time inside of this loop within __gitcomp,
> due to the string copying overhead....
> ...
>  Does this make things better?  Or worse?  I'm not seeing a huge
>  difference on my own system.  Maybe its too fast these days...

Ingo, I understand you have stopped using the completion long time ago due to this latency issue. Together with d773c63 (bash: offer only paths after '--', 2008-07-08) that already is in 'maint' and 'master', this hopefully would make the completion usable for you again?

Previous: Johannes SchindelinNext: Ingo Molnar
Message 4 of 5 in “bash completion: Improve responsiveness of git-log completion”
  1. bash completion: Improve responsiveness of git-log completionShawn O. Pearce, Jul 13, 2008
  2. Petr BaudisJul 13, 2008
  3. Johannes SchindelinJul 13, 2008
  4. Junio C HamanoJul 13, 2008
  5. Ingo MolnarJul 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.