Re: Patch for NO_R_TO_GCC_LINKER

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 13, 2008, 20:10 UTC
Message-ID: <7vy730n0ac.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <c475e2e60808130342r452fae1cm7d08d8d2206d0468@mail.gmail.com>

"Giovanni Funchal" <gafunchal@gmail.com> writes:

Show 13 quoted lines

> diff --git a/Makefile b/Makefile
> index 90c5a13..6e20b08 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -111,9 +111,8 @@ all::
>  #
>  # Define NO_DEFLATE_BOUND if your zlib does not have deflateBound.
>  #
> -# Define NO_R_TO_GCC_LINKER if your gcc does not like "-R/path/lib"
> -# that tells runtime paths to dynamic libraries;
> -# "-Wl,-rpath=/path/lib" is used instead.
> +# LD_RUNPATH_SWITCH specifies how to pass the runtime dynamic library paths
> +# to the linker. The default is "-Wl,-rpath,".

Can you make your change to configure.ac to minimize changes to the Makefile?

In this project, use of configure is strictly optional and Makefile is more canonical than autoconf generated configure. Unless absolutely necessary, I'd prefer to have a solution that does _not_ change the set of make variables people need to override from the command line.

Changes to configure.ac so that generated script sets NO_R_TO_GCC_LINKER appropriately would fit the current model much better and would not break people's existing setups that do not use configure.