Re: [PATCH/RFC v1 3/6] cleanup of write_entry() in entry.c

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2009, 21:31 UTC
Message-ID: <7vy6wvkth1.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1233004637-15112-4-git-send-email-barvik@broadpark.no>

Kjetil Barvik <barvik@broadpark.no> writes:

Show 14 quoted lines

> The switch-cases for S_IFREG and S_IFLNK was so similar that it will
> be better to do some cleanup and use the common parts of it.
>
> Also fold the longest lines such that no line is longer then 80 chars
> or so.
>
> And the entry.c file should now be clean for 'gcc -Wextra' warnings.
>
> Signed-off-by: Kjetil Barvik <barvik@broadpark.no>
> ---
>
> If people do not like this approach I can be willing to drop it from
> this patch-series, but then I get some source code duplication from
> the next patch (4/6).

Merging of the two similar codepaths looked good from a cursory reading, but if you have doubts about one patch, it usually is easier for other people to work with you if the series is reordered to have it near the end, iow, undisputably good ones first.

Show 5 quoted lines

> -			return error("git checkout-index: unable to read sha1 file of %s (%s)",
> -				path, sha1_to_hex(ce->sha1));
> +			return error("git checkout-index: "\
> +				     "unable to read sha1 file of %s (%s)",
> +				     path, sha1_to_hex(ce->sha1));

You lost greppability when somebody calls for help saying "I am getting an error message that says 'git checkout-index: unable to read sha1 file'".