Re: [RFC] add test cases for the --repo option to git push

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2009, 17:34 UTC
Message-ID: <7vy6vrkcmo.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <49A7C3A7.6060202@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 18 quoted lines

> Junio C Hamano venit, vidit, dixit 26.02.2009 18:09:
>> Michael J Gruber <git@drmicha.warpmail.net> writes:
>> 
>>> First of all: I define good/bad as matching the documentation.
>> 
>> Ok, I was primarily working from this:
>> 
>> commit bcc785f611dc6084be75999a3b6bafcc950e21d6
>> Author: Linus Torvalds <torvalds@osdl.org>
>> Date:   Mon Oct 30 08:28:59 2006 -0800
>
>
> [snip]
>> You will see that:
>> 
>>  (1) bf07cc5 (i.e. J6t's documentation) passes your tests;
>
> Hmm, I don't see that, we must be doing something differently, see below.

No, I didn't even know if the commit passed your tests. Before the [snip] I think I had something like:

	If your claim that this is a bug is true, it might have happened
	this way: Linus originally wrote it, behaviour changed, J6t
	documented the updated behaviour, behaviour changed again.

and after (1)/(2)/..., I have:

>> if the above conjecture is true, and we may want to fix that regression to
>> match the documentation.

So if you don't see that, it merely proves that the conjecture is false. The updated documentation didn't describe correctly what should happen and there is no bug other than in the documentation.

It's a different matter if we want to update the semantics, but I am not sure if people agree with "the documented version is more natural". I'm neutral right now. I may have more to say after I re-read the detailed analysis part of your message.