git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/6] grep: add option -p/--show-function

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 2, 2009, 05:27 UTC
Message-ID
<7vy6r7d583.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4A4C39D3.1020401@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 12 quoted lines
> Hmm, even shorter would be to leave out these "==" things entirely:
>
> 	# mock-up
> 	$ git grep -p -n markers grep.c
> 	grep.c=746=static void clr_hit_marker(struct grep_expr *x)
> 	grep.c:748:     /* All-hit markers are meaningful only at...
> 	grep.c=760=static int chk_hit_marker(struct grep_expr *x)
> 	grep.c:762:     /* Top level nodes have hit markers.  See...
> 	grep.c=772=int grep_buffer(struct grep_opt *opt, const ch...
> 	grep.c:782:      * We first clear hit markers from them.
>
> Is that still readable?
Actually the above matches what I expected to see when I read your [0/6].

Is the use of '=' your invention, or does somebody's grep have this function header feature already and use '=' the same way?

Previous: René ScharfeNext: René Scharfe
Message 12 of 15 in “grep: add option -p/--show-function, similar to diff's”
  1. 0/6 grep: add option -p/--show-function, similar to diff'sRené Scharfe, Jul 1, 2009
  2. 1/6 userdiff: add xdiff_clear_find_func()René Scharfe, Jul 1, 2009
  3. 2/6 grep: move context hunk mark handling into show_line()René Scharfe, Jul 1, 2009
  4. Junio C HamanoJul 1, 2009
  5. René ScharfeJul 2, 2009
  6. Junio C HamanoJul 2, 2009
  7. 3/6 grep: print context hunk marks between filesRené Scharfe, Jul 1, 2009
  8. 4/6 grep: handle pre context lines on demandRené Scharfe, Jul 1, 2009
  9. 5/6 grep: add option -p/--show-functionRené Scharfe, Jul 1, 2009
  10. Junio C HamanoJul 2, 2009
  11. René ScharfeJul 2, 2009
  12. Junio C HamanoJul 2, 2009
  13. René ScharfeJul 2, 2009
  14. René ScharfeJul 2, 2009
  15. 6/6 grep -p: support user defined regular expressionsRené Scharfe, Jul 1, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.