Re: [PATCH] Fix the exit code of MSVC build scripts on cygwin

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 9, 2009, 06:49 UTC
Message-ID: <7vy6nl5ag0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <81b0412b0910081313x31f72916p6fddd1a23df154df@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 17 quoted lines

> On Thu, Oct 8, 2009 at 17:33, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:
>> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
>> index 0ffd59f..26aec61 100644
>> --- a/compat/vcbuild/scripts/clink.pl
>> +++ b/compat/vcbuild/scripts/clink.pl
>> @@ -45,4 +45,6 @@ if ($is_linking) {
>>        push(@args, @cflags);
>>  }
>>  #printf("**** @args\n");
>> -exit system(@args);
>> +system(@args) == 0
>> +       or exit 1;
>> +exit 0;
>
> exit(system(@args) != 0);
>
> Yours looks a little verbose...

Thanks, will queue with a fixup.