Re: [PATCH 0/2] Add optional parameters to the diff option "--ignore-submodules"

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 8, 2010, 23:26 UTC
Message-ID: <7vy6epqf5y.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.1006082247390.1732@bonsai2>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 13 quoted lines

> I agree that the basic reason for the default to check for dirty and 
> untracked files is sound.
>
> It is not your (Jens') fault that this does not integrate well into the 
> Git context, and that users of the submodule feature were punished that 
> heavily (just to reiterate, if anybody missed that number, the time on 
> "git status" -- or for that matter, "git diff" -- went up by >4500%. In 
> English words, that is four-thousand five hundred percent, and that is 
> just a lower bound).
>
> So I would actually argue (being a real submodule user, not just an 
> imaginary one) that the default for dirty checking in the submodules 
> should stay.

Let me make sure I understand. You repeated three times that you suffered big time spending too many cycles due to extra checks (compared with older behaviour of not checking submodule working tree at all), but you would recommend the default to be the expensive one?

I am not trying to point out that these two statements are inconsistent. I am guessing that you are suggesting to "default to safe-but-expensive, let people who know what they are doing to tweak for performance", but you are as always a bit too terse for me to be sure, hence this question.