Re: [PATCH/resend] Doc: git-push: Specify the default mode in the description

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 8, 2010, 20:48 UTC
Message-ID: <7vy693o833.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1289222435-9610-1-git-send-email-santi@agolina.net>

Santi Béjar <santi@agolina.net> writes:

Show 5 quoted lines

> Signed-off-by: Santi Béjar <santi@agolina.net>
> ---
> Hi *,
>
>   just resend a patch that maybe was missed inside this thread:

No, I didn't miss it.

The new text says 'push "matching" branches' before explaining what it is, only vaguely refers the reader to the next section by "see below" without telling which part of below the reader should look at. In other words, it wastes two lines without adding two lines worth of additional information.

Saying "look for string 'default' below" might be an improvement ;-), but then the reader can do that without being told to do so themselves, so...

Show 25 quoted lines

> Subject:    possible bug when pushing with multiple remote repos.
> From:       Arnaud Mouiche
> Date:       2010-10-22 9:12:51
> http://marc.info/?i=1287738771.13348.34.camel%20()%20amolinux
>
> Santi
>
>  Documentation/git-push.txt |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index e11660a..9a2a93e 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -23,6 +23,8 @@ You can make interesting things happen to a repository
>  every time you push into it, by setting up 'hooks' there.  See
>  documentation for linkgit:git-receive-pack[1].
>  
> +The default operation mode if no explicit refspec is found is
> +to push "matching" branches, see below.
>  
>  OPTIONS[[OPTIONS]]
>  ------------------
> -- 
> 1.7.3.2.337.gc40334