Re: [PATCH] gitweb: Make $prevent_xss protection for 'blob_plain' more usable

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2011, 23:12 UTC
Message-ID: <7vy615mily.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201106132350.00161.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 11 quoted lines

>> Hmph, wouldn't it be more straightforward if you dropped the statement
>> modifier?  I.e.
>> 
>> 	my ($subtype, $rest) = ($1, $2);
>> 	$rest = '' unless defined $rest;
>> 	$type = "text/plain$rest";
>
> Yes, of course.
>
> I don't know why I decided that avoiding rewriting 'text/plain; 
> charset=utf-8' case was important.

Just to make sure I understand what you are saying...

    my $type = 'text/plain; charset=utf-8';
    if ($type =~ m|^text/([a-z]+)\b(.*)$|) {
 	my ($subtype, $rest) = ($1, $2);
 	$rest = '' unless defined $rest;
 	$type = "text/plain$rest";
        print "Type is now <$type>\n";
    }

does yield "text/plain; charset=utf-8". It does rewrite but rewrite to exactly the same thing, so...