Re: [PATCH v3 4/4] upload-archive: use start_command instead of fork
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 3, 2011, 18:39 UTC
- Message-ID
- <7vy5x1gbr6.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1317329963-6656-5-git-send-email-kusmabite@gmail.com>
Erik Faye-Lund <kusmabite@gmail.com> writes:
> Add an undocumented flag to git-archive that tells it that the > action originated from a remote, so features can be disabled.
Show 31 quoted lines
> diff --git a/builtin/upload-archive.c b/builtin/upload-archive.c
> index 2d0b383..c57e8bd 100644
> --- a/builtin/upload-archive.c
> +++ b/builtin/upload-archive.c
> @@ -6,6 +6,7 @@
> #include "archive.h"
> #include "pkt-line.h"
> #include "sideband.h"
> +#include "run-command.h"
>
> static const char upload_archive_usage[] =
> "git upload-archive <repo>";
> @@ -18,28 +19,17 @@ static const char lostchild[] =
>
> #define MAX_ARGS (64)
>
> -static int run_upload_archive(int argc, const char **argv, const char *prefix)
> +static void prepare_argv(const char **sent_argv, const char **argv)
> {
> - const char *sent_argv[MAX_ARGS];
> const char *arg_cmd = "argument ";
> char *p, buf[4096];
> int sent_argc;
> int len;
>
> + sent_argc = 2;
> + sent_argv[0] = "archive";
> + sent_argv[1] = "--remote-request";
> for (p = buf;;) {
> /* This will die if not enough free space in buf */
> len = packet_read_line(0, p, (buf + sizeof buf) - p);Hmm, forgetting the "Windows" for a while, does this client work against the remote repositories that are running deployed versions of Git?