Re: [PATCH] stash show: use default pretty format

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2012, 19:06 UTC
Message-ID: <7vy5tc210y.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1326351953-3724-1-git-send-email-rctay89@gmail.com>

Tay Ray Chuan <rctay89@gmail.com> writes:

Show 8 quoted lines

> By default (ie. when stash show is invoked without any arguments), the
> diff stat of the stashed changes is displayed. Let git-diff decide the
> default pretty format to use.
>
> This gives git more consistency, as users who have set their
> pretty.format config would naturally expect `git-stash show` to display
> the diff in the same pretty format as the other diff-producing procelain
> like git-log and git-show.

A handful of issues:

 - The stash entries, unlike the usual commits you store on branches and
   inspect with "show", are designed to be quick escapes for emergency
   interruption, and "--stat" is a good default to remind the user what
   she was working on before she was interrupted _without_ scrolling the
   top of the screen away by showing the full diff.  Careful design
   decisions far outweigh mechanical application of "consistency for the
   sake of consistency".

 - What does "pretty.format" has anything to do with "stash"?

 - If it does, why doesn't the script read from it?

 - How does this justify the UI regression for people who are used to the
   good default "--stat" they have been seeing?