Re: [PATCH] mergetool: support --tool-help option like difftool does
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 23, 2012, 22:31 UTC
- Message-ID
- <7vy5mahzyv.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAHGBnuNvzoSkrujoxLt-M5VS2Pm=e6CL_P39pyRAv-NEi1y6QA@mail.gmail.com>
Sebastian Schuberth <sschuberth@gmail.com> writes:
Show 11 quoted lines
> On Mon, Jul 23, 2012 at 11:16 PM, Junio C Hamano <gitster@pobox.com> wrote: > >> There are only five or six classes of environment that matter in the >> real world for the purpose of giving "well known" examples: Windows, >> MacOS X, Gnome, KDE and Linux terminal. By picking a representative >> one from each and listing them, the end result would have at least >> one that people from various platforms have _heard of_ and can guess >> what they do. The "most common" is secondary, and "well known" is > > I completely agree with this. So we should take the chance and add a > Windows representative to the list of difftools, no?
I do not care very deeply either way. I am more interested in seeing --tool-list options supported by both so that we can get rid of hardcoded list from the completion script.
> This drops the explicit mention of --tool-help as an option in the > documentation compared to my patch. Do you want to keep --tool-help > being mentioned inline as part of the --tool option documentation > only?
While I do not think having one would hurt that much, I do not think a separate entry would add much value either, so I chose not to clutter the documentation further. The "--tool=<tool>" entry is enough hint to draw eyes of readers who want to find out what kind of backends are supported, and --tool-help is mentioned there quite prominently.