Re: [RFC/PATCH 2/8 v2] git_remote_helpers: fix input when running under Python 3
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 15, 2013, 22:04 UTC
- Message-ID
- <7vy5fu14sy.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20130115215412.GX4574@serenity.lan>
John Keeping <john@keeping.me.uk> writes:
Show 7 quoted lines
>> That really feels wrong. Displaying is a separate issue and it is >> the _right_ thing to punt the problem at the lower-level machinery >> level. > > But the display will require decoding the ref name to a Unicode string, > which depends on the encoding of the underlying ref name, so it feels > like it should be decoded where it's read (see [1]).
If you botch the decoding in a way you cannot recover the original byte string, you cannot create a ref whose name is the original byte string, no? Keeping the original byte string internally (this includes where you use it to create new refs or update existing refs), and attempting to convert it to Unicode when you choose to show that string as a part of a message to the user (and falling back to replacing some bytes to '?' if you cannot, but do so only in the message), you won't have that problem.