git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] count-objects: report garbage files in .git/objects/pack directory too

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 4, 2013, 17:06 UTC
Message-ID
<7vy5f42elc.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1359982145-10792-2-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>  The hook in prepare_packed_git_one is ugly, but I don't want to
>  duplicate the search file logic there in count-objects. Maybe I'm
>  wrong.

In this particular case I do not think you are completely wrong; you are probably only two thirds wrong ;-)

The idea to use a customizable function pointer to allow it do extra work is probably fine, but adding three identical calls and continue is a bad taste. Just have one callsite for the error path and do not hesitate to jump to it with 'goto'.

I do not think failure to add_packed_git() should be treated the same way as other cases where the files readdir() found are truly garbage, by the way.

I also wonder, especially because you are enumerating the temporary pack files in .git/objects/pack/, if it make more sense to account for their sizes as well. After all, you would end up doing stat() for a common case of files with ".pack" suffix---doing so for all of them shouldn't be too bad.

Previous: Nguyễn Thái Ngọc DuyNext: Junio C Hamano
Message 3 of 14 in “git-count-objects.txt: describe each line in -v output”
  1. 1/2 git-count-objects.txt: describe each line in -v outputNguyễn Thái Ngọc Duy, Feb 4, 2013
  2. 2/2 count-objects: report garbage files in .git/objects/pack directory tooNguyễn Thái Ngọc Duy, Feb 4, 2013
  3. Junio C HamanoFeb 4, 2013
  4. Junio C HamanoFeb 4, 2013
  5. Duy NguyenFeb 7, 2013
  6. Junio C HamanoFeb 7, 2013
  7. Duy NguyenFeb 7, 2013
  8. 0/3 count-objects improvementsNguyễn Thái Ngọc Duy, Feb 8, 2013
  9. 1/3 git-count-objects.txt: describe each line in -v outputNguyễn Thái Ngọc Duy, Feb 8, 2013
  10. 2/3 count-objects: report garbage files in pack directory tooNguyễn Thái Ngọc Duy, Feb 8, 2013
  11. Junio C HamanoFeb 8, 2013
  12. Duy NguyenFeb 9, 2013
  13. 3/3 count-objects: report how much disk space taken by garbage filesNguyễn Thái Ngọc Duy, Feb 8, 2013
  14. Junio C HamanoFeb 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.