Re: [PATCH 1/3] contrib/subtree: stop explicitly using a bash shell

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 25, 2013, 17:57 UTC
Message-ID: <7vy5dbxszy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1364153863-27437-2-git-send-email-pcampbell@kemitix.net>

Paul Campbell <pcampbell@kemitix.net> writes:

Show 22 quoted lines

> Don't explicitly use the Bash shell but allow the system to provide a
> hopefully POSIX compatible shell at /bin/sh.
>
> Signed-off-by: Paul Campbell <pcampbell@kemitix.net>
> ---
>
> Only the system's I was able to test this on (Debian squeeze) /bin/sh is
> the dash shell.
>
>  contrib/subtree/git-subtree.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh
> index 8a23f58..5701376 100755
> --- a/contrib/subtree/git-subtree.sh
> +++ b/contrib/subtree/git-subtree.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>  #
>  # git-subtree.sh: split/join git repositories in subdirectories of this one
>  #

Interesting. I'll leave the final "yeah, this is safe" declaration to David and Avery, but I've always assumed without checking that this script relied on bash-isms like local variable semantics, arrays, regexp/substring variable substitutions, etc.

With a quick scan, however, I do not seem to find anythning glaringly unportable.