Re: [PATCH] push: Alias pushurl from push rewrites
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 28, 2013, 16:10 UTC
- Message-ID
- <7vy5d7v71o.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20130328160104.GC16034@leaf>
Josh Triplett <josh@joshtriplett.org> writes:
Show 11 quoted lines
> OK, I take it back. I *can* imagine configurations that this change > would break, since it does change intentional and documented behavior, > but I don't have any such configuration. The only such configuration I > can imagine involves directly counting on the non-rewriting of pushUrl, > by using pushInsteadOf to rewrite urls and then sometimes using pushUrl > to override that and point back at the un-rewritten URL. And while > supported, that does seem *odd*. > > Objection withdrawn; if nobody can come up with a sensible configuration > that relies on the documented behavior, I don't particularly care if it > changes.
I actually do.
Given the popularity of the system, "people involved in this thread cannot imagine a case that existing people may get hurt" is very different from "this is not a regression". After merging this change when people start complaining, you and Rob can hide and ignore them, but we collectively as the Git project have to have a way to help them when it happens.