Re: [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2013, 15:20 UTC
Message-ID: <7vy5bsrv73.fsf@alter.siamese.dyndns.org>
In-Reply-To: <6bb37f45280373b96c2ae581db9bd87007dc0fb7.1367843730.git.john@keeping.me.uk>

John Keeping <john@keeping.me.uk> writes:

Show 9 quoted lines

> Commit 54bb901 (t/Makefile: fix result handling with
> TEST_OUTPUT_DIRECTORY - 2013-04-26) incorrectly defined
> TEST_RESULTS_DIRECTORY relative to itself, when it should be relative to
> TEST_OUTPUT_DIRECTORY.  Fix this.
>
> Signed-off-by: John Keeping <john@keeping.me.uk>
> ---
>  t/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, I missed this one.

Show 13 quoted lines

> diff --git a/t/Makefile b/t/Makefile
> index 11de5da..ebb7371 100644
> --- a/t/Makefile
> +++ b/t/Makefile
> @@ -16,7 +16,7 @@ DEFAULT_TEST_TARGET ?= test
>  TEST_LINT ?= test-lint-duplicates test-lint-executable
>  
>  ifdef TEST_OUTPUT_DIRECTORY
> -TEST_RESULTS_DIRECTORY = $(TEST_RESULTS_DIRECTORY)/test-results
> +TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results
>  else
>  TEST_RESULTS_DIRECTORY = test-results
>  endif