Re: git-rev-list: make --dense the default (and introduce "--sparse")

From: Junio C Hamano <junkio@cox.net>
Date: Oct 26, 2005, 09:17 UTC
Message-ID: <7vwtk08wnx.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0510251525540.10477@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 5 quoted lines

> On Tue, 25 Oct 2005, Linus Torvalds wrote:
>> 
>> This actually does three things:
>> 
>>  - make "--dense" the default for git-rev-list...

Heads up.

I have not looked closely into what exactly, but the fourth thing this does might be to break git-send-pack.

I usually use the tip of "pu" myself, but for tonight, I am excluding the fetch-pack/upload-pack changes from Johannes when building git for my own use, and using somewhere in the middle of "pu" branch. With this "--dense default" patch, git-send-pack seems to send too few objects. With this patch reverted, git-send-pack seems to work again.

 +  [build] Revert "git-rev-list: make --dense the default (and introduce "--sparse")"
 ++ [pu^] Merge branch 'js-fat'
 ++ [pu^^2] Test in git-init-db if the filemode can be trusted
 ++ [pu~2] Merge branches 'cache-pack', 'lazy-subdir' and 'lt-dense'
 ++ [pu~2^4] git-rev-list: make --dense the default (and introduce "--sparse")
 ++ [pu~2^3] Create object subdirectories on demand (phase II)
 ++ [pu~2^2] Allow caching of generated pack for full cloning.
+++ [master] upload-pack: tighten request validation.

I'll take a look at the issue in the morning unless somebody else beats me to it.