Re: git-send-mail in sh

From: Junio C Hamano <junkio@cox.net>
Date: Nov 25, 2005, 18:30 UTC
Message-ID: <7vwtiwmvfp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <43874935.2080804@op5.se>

Andreas Ericsson <ae@op5.se> writes:

> It doesn't CC them, but any number of email-addresses can be specified 
> on the command line (so long as they don't include spaces, but that can 
> be taken care of).

Again I do not think I'd ever use that feature from the original send-email myself, but the difference is that this CC list depends on each commit (sign-offs taken from a commit are added to CC list for only that commit).

Show 10 quoted lines

>>  * <bottom>..<top> pair is to format changes in <top> but not in
>>    <bottom>; typically <top> is the name of a topic branch, and
>>    <bottom> is typically "origin".  This is to encourage the use
>>    of topic branches.
>
> Would that be
>
> 	git-send-patch origin..HEAD
>
> to get the changes in the current branch since head?

Yes, and that could be spelled "git-send-patch ..HEAD" as well, if we go with my suggestion to default <bottom> to "origin".

>>  * <commit> is a shorthand for <commit>^1..<commit>; this is to
>>    allow you to quickly pick just one commit and send it out.
>
> Marvellous the things one learn. I didn't know about that syntax before. :)

Just to make sure you did not misunderstand me, I meant: the proposed program acts as if <commit>^1..<commit> was given when single <commit> is given.

But you are right. We could make a single <commit> a short-hand for "origin"..<commit>; if somebody wants to pick just one commit from a topic branch, he can always say <commit>^1..<commit>.

> I'm wondering if it wouldn't be better to move much of 
> git-format-patch's functionality to git-send-patch and support a 
> "--todisk" option. After all, how many patches are created but not sent 
> anywhere?

Manymanymanymanymany. I do all my rebases and cherry-picks via format-patch piped to git-am, and obviously they are never sent out.