Re: [PATCH] Fix linking with OpenSSL

From: Junio C Hamano <junkio@cox.net>
Date: May 4, 2006, 22:38 UTC
Message-ID: <7vwtd12z6h.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060504222550.GA7236@mipter.zuzino.mipt.ru>

Alexey Dobriyan <adobriyan@gmail.com> writes:

Show 15 quoted lines

> For those who put it into interesting (read: default) place.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> --- a/Makefile
> +++ b/Makefile
> @@ -559,7 +559,7 @@ git-http-push$X: revision.o http.o http-
>  
>  git-rev-list$X: rev-list.o $(LIB_FILE)
>  	$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> -		$(LIBS) $(OPENSSL_LIBSSL)
> +		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
>  
>  init-db.o: init-db.c
>  	$(CC) -c $(ALL_CFLAGS) \

We used to depend on bignum from openssl for rev-list (merge-order), and if I remember correctly that was the only reason built recipe for rev-list is different from other programs. I wonder if we can just get rid of this thing, and have it built with git-%$X rule like everybody else.

Can somebody try that out and report what happens?