Re: [PATCH 4/5] commit: allow --pretty= args to be abbreviated

From: Junio C Hamano <junkio@cox.net>
Date: May 14, 2006, 23:47 UTC
Message-ID: <7vwtcoyxs2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1147619963765-git-send-email-normalperson@yhbt.net>

Eric Wong <normalperson@yhbt.net> writes:

>  commit.c |   42 +++++++++++++++++++++++++++++-------------
>  1 files changed, 29 insertions(+), 13 deletions(-)

This is applicable without the gitopt changes, but I have a feeling that when we think about abbreviations the users would expect the leading substring abbreviation, not strstr().

While "git log --pretty=lle" or "git log --pretty=or" might be unambiguous, I think that is trying to be too cute and confusing, especially if somebody picks up that habit by watching others type such a cute abbreviations.

That comment probably incidentally applies to your bigger patches.