Re: [PATCH 4/4] gitweb: No periods for error messages

From: Junio C Hamano <junkio@cox.net>
Date: Aug 5, 2006, 07:03 UTC
Message-ID: <7vwt9nekay.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060805010307.17651.qmail@web31807.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

Show 10 quoted lines

> --- Junio C Hamano <junkio@cox.net> wrote:
>
>> I tend to prefer ending each sentence with a full stop.
>
> I've never seen this in, among other things,
>   - kernel messages
>   - errno messages
>   - web server messages
>   - RFC text describing error messages, (web services),
>   - etc.

Comparing

	git grep \( -e die --or -e die \) --and -e '\."' -- '*.c'

and

	git grep \( -e die --or -e die \) --and --not -e '\."' -- '*.c'

tells me that we omit periods, mostly.

> I was going for was consistency.  I'd say apply Jacob's [6/5].

Well, [6/5] is on top of [1/5] which had the problem of parroting unsanitized user input, so I'd rather use a clean patch that does only this error message cleanups.