Re: Strange output of git-diff-tree

From: Junio C Hamano <junkio@cox.net>
Date: Aug 9, 2006, 19:26 UTC
Message-ID: <7vwt9h3e35.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vbqqt4vct.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 20 quoted lines

> Junio C Hamano <junkio@cox.net> writes:
>
>> Jakub Narebski <jnareb@gmail.com> writes:
>>
>>> First (noticed by matled) is that for git-diff-tree with single tree
>>> as an argument it outputs fist commit-id of commit given at input. 
>>> It is not mentioned in documentation and I think totally unnecessary:
>>>
>>> 1038:jnareb@roke:~/git> git diff-tree --abbrev origin
>>> d5dc6a76d49367cddc015e01d2e9aa22e64d7e28
>>> :040000 040000 44fb36d... 1c26294... M  Documentation
>>
>> Working as specified as in the original version.  See
>> core-tutorial and look for "git-diff-tree -p HEAD".
>
> My mistake -- if you are talking about the first line that shows
> the commit object name, I am not sure if this was from the
> beginning or a recent slip-up.  Will need to look into it.
>
> I thought you were talking about 1-argument diff-tree, sorry.

Turns out that git-diff-tree from 1.0.0 behaves this way. Since 7384889 (May 18, 2005), one-tree form of diff-tree showed the "header" line that has the commit object name at the top, and since 1809266 (Jun 23, 2005) we have exactly one commit object name there; before that we used to say "commitA (from commitB)".

I agree that showing the single argument that is given on the command line as the first output line might seem redundant, but it has been done this way for a long time (eternity in git timescale), so let's not risk breaking people's scripts by changing it.