Re: [PATCH] detached HEAD -- finishing touches

From: Junio C Hamano <junkio@cox.net>
Date: Feb 2, 2007, 02:38 UTC
Message-ID: <7vwt31l1vo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <87d54t9vs7.wl%cworth@cworth.org>

Carl Worth <cworth@cworth.org> writes:

Show 14 quoted lines

> On Thu, 01 Feb 2007 17:30:40 -0800, Junio C Hamano wrote:
>> I do not think of any offhand, but "did we make commit since we
>> detached HEAD" was not a suggestion I made, so what I can think
>> of does not matter much ;-).
>
> Well, the suggestion I made was to:
>
> 1. Print the name of the commit we are leaving
>
> 2. Refuse to leave if what we are leaving would leave commits
>    dangling, (and print a revision specification for those set of
>    commits).
>
> Do you have a reaction to that?

Not having thought things through, I am very tempted to say that we can leave things as they are, and when the reflog for HEAD materializes, just remove the check from the codepath that makes your HEAD point at an existing branch again. With the reflog on HEAD, you do not need to be reminded of which commit you are leaving so there is no need for 1 above, and you would not lose your point (either connected or disconnected) so there is no need for 2 above either.