git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] Correct comment in prepare_packed_git_one.

From
Junio C Hamano <junkio@cox.net>
Date
Feb 2, 2007, 06:21 UTC
Message-ID
<7vwt31jd0q.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070201205227.GB19009@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
> After staring at the comment and the associated for loop, I
> realized the comment was completely bogus.

Yeah, when the comment was written, the loop after the comment did not exist. The comment was talking about calling add_packed_git() to see if the corresponding pack can be mapped, and then upon receiving NULL, not linking p to the packed_git linked list.

Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 2 of 4 in “Correct comment in prepare_packed_git_one.”
  1. 2/4 Correct comment in prepare_packed_git_one.Shawn O. Pearce, Feb 1, 2007
  2. Junio C HamanoFeb 2, 2007
  3. 3/4 Refactor open_packed_git to return an error code.Shawn O. Pearce, Feb 1, 2007
  4. 4/4 Don't find objects in packs which aren't available anymore.Shawn O. Pearce, Feb 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.